CAcert Code Development list.

[Michael Tänzer <michael.taenzer AT cacert.org>]

Hi Wytze,

On 24.09.2014 10:09, Wytze van der Raay wrote:
> On 09/24/2014 09:00 AM, Benny Baumann wrote:

>> The script can be found in the latest version of the release branch as
>> scripts/send_policy_cca_20140916.php or attached to this mail.
>>
>> Please report any issues with the execution of the script back to
>> Software and the Policy Officer.
> 
> The script has been added to the CVS, and is currently running.
> However, I need to point out that there is a bug in the script which
> obscures its logging somewhat and essentially defeats the restart
> mechanism based on the 'lastid' file:

> Since the script is running already, and is pushing out the e-mails as
> desired, there is no urgent need for a fix. But it would be wise to
> push a bug fix some time sooner or later, so the archives will contain
> a properly working version of the script, for possible future cases.

When I merged the current tarball version I noticed that the fix was
already in the release branch but not yet in the tarballs. So please
apply the attached diff.

-- 
Cheers,
Michael Tänzer
diff --git a/scripts/send_policy_cca_20140916.php b/scripts/send_policy_cca_20140916.php
index 6de5207..4d8cd66 100644
--- a/scripts/send_policy_cca_20140916.php
+++ b/scripts/send_policy_cca_20140916.php
@@ -108,12 +108,12 @@ $count = 0;
 
 $query = "
 
-	SELECT `fname`, `lname`, `email`
+	SELECT `id`, `fname`, `lname`, `email`
 	FROM `users`
 	WHERE `deleted` = '0000-00-00 00:00:00'
 	AND `modified` != '0000-00-00 00:00:00'
 	AND `verified` = '1'
-
+	AND `id` >= '$lastid'
 	ORDER BY `id`";
 
 $res = mysql_query($query);

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature