Skip to Content.
Sympa Menu

cacert-devel - Re: Setting up a test machine

Subject: CAcert Code Development list.

List archive

Re: Setting up a test machine


Chronological Thread 
  • From: dirk astrath <dirk AT cacert.org>
  • To: Jan Dittberner <jandd AT cacert.org>, Brian <bdmc AT buadh-brath.com>
  • Cc: bernhard AT cacert.org, cacert-devel AT lists.cacert.org
  • Subject: Re: Setting up a test machine
  • Date: Mon, 16 Aug 2021 13:09:31 +0200

Hello,

The PHP documentation advises against short open tags [2] but we have them
all over the place. I decided against replacing all occurences in my pull
request [3] for the mysqli change to not introduce more noise for the
reviewer(s).

good idea ... ;-)

in my experience it's way easier to do small changes ... a lot of small changes instead of doing a big change ... ;-)

doing a review of a big change where these php-tags and mysql and formatting is changed will nearly be impossible (or take quite a long time) ...

... and if i now take off my reviewers hat and replace it by the critical one ...

in case we need to update a lot of files it's not easy to revert back to the previous version ... if it's only two or three it's way easier ... ;-)

kind regards,

dirk



Archive powered by MHonArc 2.6.18.

Top of Page